-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image quality control #9
Image quality control #9
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ready to merge after addressing comments.
I think this acts as s stand alone module and does not need to be integrated into the main CP pipeline. Rather the result pass/fail parquets will be merged after cytomining is complete. Thoughts??
1.image_quality_control/qc_results/NF0014_qc_results/Experiment.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this was not meant for this file, this is meant to be there LOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh unless I am misinterpreting, don't you think these files should be included that include the QC results? Happy to discuss @MikeLippincott
1.image_quality_control/qc_results/NF0016_qc_results/Experiment.csv
Outdated
Show resolved
Hide resolved
1.image_quality_control/qc_results/NF0018_qc_results/Experiment.csv
Outdated
Show resolved
Hide resolved
@MikeLippincott Thanks for the review! I am merging now! |
Jk I don't have the ability to merge, can you add me as a manager to this repo please @MikeLippincott |
Image quality control
In this PR, whole image quality control is performed to develop thresholds for blur and saturation per channel for all current patient data.