Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image quality control #9

Merged
merged 6 commits into from
Jan 13, 2025

Conversation

jenna-tomkinson
Copy link
Member

Image quality control

In this PR, whole image quality control is performed to develop thresholds for blur and saturation per channel for all current patient data.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MikeLippincott MikeLippincott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to merge after addressing comments.

I think this acts as s stand alone module and does not need to be integrated into the main CP pipeline. Rather the result pass/fail parquets will be merged after cytomining is complete. Thoughts??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was not meant for this file, this is meant to be there LOL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh unless I am misinterpreting, don't you think these files should be included that include the QC results? Happy to discuss @MikeLippincott

@jenna-tomkinson
Copy link
Member Author

@MikeLippincott Thanks for the review! I am merging now!

@jenna-tomkinson
Copy link
Member Author

Jk I don't have the ability to merge, can you add me as a manager to this repo please @MikeLippincott

@jenna-tomkinson jenna-tomkinson merged commit e03885c into WayScience:main Jan 13, 2025
@jenna-tomkinson jenna-tomkinson deleted the img_quality_control branch January 13, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants