feat: massive docs rewrite #473
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| window.onmonetization = function () { | ||
| alert('This page supports Web Monetization.') | ||
| } |
There was a problem hiding this comment.
And this will get called on each monetization event, so we should not recommend this event as this use case.
Recommended way to detect WM support is following:
const supportsMonetization: boolean = document.createElement('link').relList.supports('monetization');There was a problem hiding this comment.
...it's part of "DOM API"
There was a problem hiding this comment.
I'm aligned with what Sid is mentioning. I think the example should state something around these lines:
Show a message to site visitors to thank them for their support.
There was a problem hiding this comment.
Given Firefox & Safari don't support Permissions-Policy, but they both support iframe allow attribute, maybe this file should add some more focus on that attribute.
Also, extension doesn't support the header as of now. But it has partial support for allow attribute (interledger/web-monetization-extension#575).
| window.onmonetization = function () { | ||
| alert('This page supports Web Monetization.') | ||
| } |
There was a problem hiding this comment.
I'm aligned with what Sid is mentioning. I think the example should state something around these lines:
Show a message to site visitors to thank them for their support.
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Sid Vishnoi <[email protected]>
Co-authored-by: Sid Vishnoi <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
Co-authored-by: Radu-Cristian Popa <[email protected]>
This is the replacement PR for #463 after the main branch visual update