Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use existing convention for sdk name #226

Merged
merged 1 commit into from
Jan 21, 2025
Merged

fix: use existing convention for sdk name #226

merged 1 commit into from
Jan 21, 2025

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jan 21, 2025 •
edited
Loading

About the changes

We found that unleash-client-lang:version convention is used a lot so for the new header we can stick to it for now.

Important files

Discussion points

@kwasniew kwasniew requested a review from Tymek January 21, 2025 15:16
@kwasniew kwasniew merged commit 208cab5 into main Jan 21, 2025
39 checks passed
@kwasniew kwasniew deleted the sdk-version-existing-convention branch January 21, 2025 15:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12889988183

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.385%
Totals Coverage Status
Change from base Build 12885054715: 0.0%
Covered Lines: 434
Relevant Lines: 455
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tymek Tymek Tymek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwasniew @coveralls @Tymek