Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ruby 3.4 support in gh actions #223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rarruda
Copy link
Collaborator

@rarruda rarruda commented Jan 8, 2025

About the changes

Add github actions test also in the latest ruby release.

@rarruda rarruda requested a review from sighphyre January 8, 2025 09:23
@rarruda
Copy link
Collaborator Author

rarruda commented Jan 8, 2025

Oops! Looks like some changes are needed to make all tests pass as green in 3.4. Will take a look when i get a chance.

Should probably convert this to a draft PR in the mean time..

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12876544803

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.374%

Totals Coverage Status
Change from base Build 12414537848: 0.0%
Covered Lines: 433
Relevant Lines: 454

💛 - Coveralls

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, that looks sane to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved PRs
Development

Successfully merging this pull request may close these issues.

3 participants