Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump client spec to 5.1.9 #222

Merged
merged 3 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
os:
- ubuntu
- macos
- windows
ruby-version:
- jruby-9.4
- 3.3
Expand All @@ -48,11 +49,13 @@ jobs:
run: bundle install
- name: Get test project semver
id: get_semver
shell: bash
run: |
semver=$(ruby echo_client_spec_version.rb)
echo "::set-output name=semver::$semver"
- name: Download test cases
run: git clone --depth 5 --branch v${{ steps.get_semver.outputs.semver }} https://github.com/Unleash/client-specification.git client-specification
shell: bash
- name: Run tests
run: bundle exec rake
env:
Expand Down
2 changes: 1 addition & 1 deletion lib/unleash/spec_version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Unleash
CLIENT_SPECIFICATION_VERSION = "5.1.7".freeze
CLIENT_SPECIFICATION_VERSION = "5.1.9".freeze
end
3 changes: 2 additions & 1 deletion spec/unleash/client_specification_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@

JSON.parse(File.read(SPECIFICATION_PATH + '/index.json')).each do |test_file|
describe "for #{test_file}" do
current_test_set = JSON.parse(File.read(SPECIFICATION_PATH + '/' + test_file))
## Encoding is set in this read purely for JRuby. Don't take this out, it'll work locally and then fail on CI
current_test_set = JSON.parse(File.read(SPECIFICATION_PATH + '/' + test_file, encoding: 'utf-8'))
context "with #{current_test_set.fetch('name')} " do
tests = current_test_set.fetch('tests', [])
tests.each do |test|
Expand Down
2 changes: 1 addition & 1 deletion spec/unleash/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
'X-API-KEY' => '123',
'UNLEASH-APPNAME' => 'test-app',
'UNLEASH-INSTANCEID' => config.instance_id,
'Unleash-Client-Spec' => '5.1.7',
'Unleash-Client-Spec' => '5.1.9',
'User-Agent' => "UnleashClientRuby/#{Unleash::VERSION} #{RUBY_ENGINE}/#{RUBY_VERSION} [#{RUBY_PLATFORM}]"
}
)
Expand Down
2 changes: 1 addition & 1 deletion unleash-client.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]
spec.required_ruby_version = ">= 2.7"

spec.add_dependency "yggdrasil-engine", "~> 0.0.9"
spec.add_dependency "yggdrasil-engine", "~> 1.0.1"

spec.add_development_dependency "bundler", "~> 2.1"
spec.add_development_dependency "rake", "~> 12.3"
Expand Down
Loading