Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Unable to authenticate Qualtrics when using token-atm-app #43

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

yongkanm
Copy link
Contributor

Probelm Description

This issue is caused by FormData not supporting structured clone. To avoid SOP restriction, requests to Canvas are proxied using Electron IPC, which sends data between different processes using structured clone. As a result, FormData are not properly sent to Electron main process, so the request to Qualtrics OAuth endpoint lacks of parameters.

Solution

Fix is applied by using URL parameters to make the request rather than FormData.

Testing Note

  1. Please use token-atm-app for testing and set window.location.href in the developer console to use the local build of token-atm-spa.
  2. Please test whether a request to a token option of earning tokens by completing Qualtrics surveys could be properly processed using the Testing Note 5 from User Stories: more request handling #32.

@yongkanm yongkanm requested a review from epsilonError June 22, 2023 23:52
@yongkanm yongkanm marked this pull request as ready for review June 22, 2023 23:52
@epsilonError
Copy link
Contributor

Testing Note 1. Works as expected

@epsilonError
Copy link
Contributor

Note 2. Passes Previous Testing Note 5.iii and iv

@epsilonError
Copy link
Contributor

Note 2. Passes Previous Testing Note 5.i and ii

@epsilonError epsilonError merged commit 2a04d30 into main Jun 23, 2023
@yongkanm yongkanm self-assigned this Jun 25, 2023
@epsilonError epsilonError deleted the bugfix-qualtrics-credentials branch July 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants