Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_SIRF.py to latest signature of Algorithm run method #2071

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Feb 10, 2025

Description

The SIRF tests failed because they did not pass iteration number to the run method of the algorithm.

Example Usage

❤️ Thanks for your contribution!

Changes

Added iteration number to the call in the test

Testing you performed

Please add any demo scripts to https://github.com/TomographicImaging/CIL-Demos/tree/main/misc

Test on the SIRF VM.

Related issues/links

Checklist

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have updated the relevant documentation
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@paskino paskino requested a review from MargaretDuff February 10, 2025 12:10
Copy link
Member

@MargaretDuff MargaretDuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paskino

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Edoardo Pasca <[email protected]>
@paskino paskino merged commit ec1f3a6 into master Feb 10, 2025
11 checks passed
@paskino paskino deleted the fix_SIRF_test_v24.3.0 branch February 10, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants