climb pivot + algae flywheel #35
Conversation
…tgpt plz review it :(
src/main/java/frc/robot/subsystems/flywheel/FlywheelConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/flywheel/PhysicalFlywheel.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/flywheel/SimulatedFlywheel.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/flywheel/SimulatedFlywheel.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/flywheel/SimulatedFlywheel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Hey great job! All of my comments are just nits
As for writing docstrings, we basically want to have them for every method in any class/interface, except for if the method is from an interface the class is implementing. This is because if a class implements an interface, for all of the interface's methods that the class uses it will just keep the interface's docstrings. You can easily check if a method already has a docstring just by hovering over it in vscode (@Ishan1522 maybe you can show her)
src/main/java/frc/robot/subsystems/pivot/ClimbPivotInterface.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/pivot/PhysicalClimbPivot.java
Outdated
Show resolved
Hide resolved
nuh uh 👎 |
Co-authored-by: junocapra <[email protected]>
| } | ||
|
|
||
| /** | ||
| * angle is in rotations, idk where the angles are or what 0 is |
There was a problem hiding this comment.
A little vscode/programming trick. If you're not sure what to put somewhere, if you put TODO: blah blah jsjcdsflsji in a comment, it will highlight it so you don't forget about it later.
You don't have to commit this or anything, just for future reference
|
/format |
| */ | ||
| public class ClimbPivot extends SubsystemBase { | ||
| /** Creates a new ClimbPivot. */ | ||
| public TalonFX climbPivotMotor = new TalonFX(PivotConstants.CLIMB_PIVOT_MOTOR_ID); |
There was a problem hiding this comment.
u don't need ur motor or anyhting here, this should look similar to your FlywheelSubsystem, where you had the Interface and the InputsAutoLogged, which you used to do things and stuff
|
/format |
REVIEW REVIEWWWW