Rip out caching machinery and prepare for new Jupyterlab. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into a problem when deleting a notebook and creating a new one of the same name. We believe this might be related to caching. Even if it isn't, the caching system is no longer particularly useful. This change removes the caching machinery, and at the same time fixes several bugs and prepares us for the next version of Jupyterlab, which will require contents plugins to include the hash of the notebook file when reading it (i.e., everything that needed to be done to make it work on a freshly-installed Jupyterlab venv).
|
[sc-51518] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a problem when deleting a notebook and creating a new one of the same name. We believe this might be related to caching. Even if it isn't, the caching system is no longer particularly useful.
This change removes the caching machinery, and at the same time fixes several bugs and prepares us for the next version of Jupyterlab, which will require contents plugins to include the hash of the notebook file when reading it (i.e., everything that needed to be done to make it work on a freshly-installed Jupyterlab venv).