Add Or Mode for KeyboardKeyDefinitions #208
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for KeyboardKeyDefinitions to register as being pressed if any of their key codes are pressed (rather than requiring all of them).
In your review I ask for special attention to the last part of the Keyboard Key Pressed logic but I couldn't quite parse what the point of it was. I removed this whole part:
From what I can understand of it it says it's NOT pressed if there is any keyboard that exactly contains all the same keycodes and those keycodes are pressed? As in it's not allowing multiple to be triggered at the same time?
I don't know why you would want to explicitly disallow that.
I found that in this commit it didn't have that
https://github.com/ThoNohT/NohBoard/blob/4e2965a1bbecf6b2f342aa8f5e71ee5f819549b7/NohBoard/Forms/MainForm.cs
but in this commit it did
8e20028#diff-ddd56594eed44ee72f2d8791249520ccd6802f26bd2a5e7767331930d6598a71
but the commit message implies it was only for edit mode? So I have no idea what the point of it was.