fix crash while resource release without context

Tencent · Nov 30, 2023 · ef84e42 · ef84e42
1 parent 44ea2d5
commit ef84e42
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/src/rendering/CompositionReader.cpp b/src/rendering/CompositionReader.cpp
@@ -38,7 +38,11 @@ CompositionReader::CompositionReader(std::shared_ptr<BitmapDrawable> bitmapDrawa
 }
 
 CompositionReader::~CompositionReader() {
+  auto result = drawable->lockDevice();
   delete pagPlayer;
+  if (result) {
+    drawable->unlockDevice();
+  }
 }
 
 std::shared_ptr<PAGComposition> CompositionReader::getComposition() {

diff --git a/src/rendering/drawables/BitmapDrawable.cpp b/src/rendering/drawables/BitmapDrawable.cpp
@@ -41,6 +41,14 @@ void BitmapDrawable::setBitmap(std::shared_ptr<BitmapBuffer> buffer) {
   freeSurface();
 }
 
+bool BitmapDrawable::lockDevice() {
+  return device->lockContext() != nullptr;
+}
+
+void BitmapDrawable::unlockDevice() {
+  device->unlock();
+}
+
 void BitmapDrawable::present(tgfx::Context* context) {
   if (bitmap == nullptr) {
     return;

diff --git a/src/rendering/drawables/BitmapDrawable.h b/src/rendering/drawables/BitmapDrawable.h
@@ -40,6 +40,10 @@ class BitmapDrawable : public Drawable {
     return pixelCopied;
   }
 
+  bool lockDevice();
+
+  void unlockDevice();
+
  protected:
   std::shared_ptr<tgfx::Device> onCreateDevice() override {
     return device;

diff --git a/src/rendering/drawables/Drawable.cpp b/src/rendering/drawables/Drawable.cpp
@@ -60,7 +60,11 @@ std::shared_ptr<tgfx::Surface> Drawable::getSurface(tgfx::Context* context, bool
 }
 
 void Drawable::freeSurface() {
+  auto context = lockContext(false);
   surface = nullptr;
+  if (context != nullptr) {
+    device->unlock();
+  }
 }
 
 }  // namespace pag