-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve and add new replacements to the dataset module #403
feat: improve and add new replacements to the dataset module #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Estos cambios son nuevas funcionalidades, así que el título de la PR debería ser algo tipo feat: improve and add new replacements to the dataset module
Y habría que añadir un pequeño resumen en inglés a la descripción de la PR, que queda muy triste vacía.
Co-authored-by: Pablo Guijarro <[email protected]>
Co-authored-by: Pablo Guijarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algunos comentarios más.
Y sigue faltando una pequeña descripción en la PR, como comentaba aquí: #403 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faltaría añadir la nueva transformación ROUND al summary.
Co-authored-by: Pablo Guijarro <[email protected]>
Co-authored-by: Pablo Guijarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Climate has analyzed commit b650606 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
DICT
and `LIST`` replacement. Example: [DICT:{"key": true}], [LIST:[null]]REPLACE
replacement, to replace a substring with another. Example: [REPLACE:[CONTEXT:some_url]::https::http]TITLE
replacement, to apply Python's title() function. Example: [TITLE:the title]ROUND
replacement, float number to a string with the indicated number of decimals. Example: [ROUND:3.3333::2]