Add chevron option to title link #371
Conversation
| @@ -133,6 +133,7 @@ | |||
| </attr> | |||
| <attr name="link" format="string" /> | |||
| <attr name="linkOnClick" format="string" /> | |||
| <attr name="linkWithChevron" format="boolean"/> | |||
There was a problem hiding this comment.
named "linkWithChevron" because withChevron attr already declared
DevPabloGarcia
requested review from
a team,
jeslat,
dagonco and
aweell
and removed request for
a team
|
📱 New catalog for testing generated: Download |
| @@ -84,8 +91,10 @@ class TitleView @JvmOverloads constructor( | |||
| ) | |||
| .takeIf { it } | |||
| ?.let { setTitleHeading() } | |||
|
|
|||
| linkTextView.setTextAndVisibility(styledAttrs.getText(R.styleable.TitleView_link)) | |||
| val text = styledAttrs.getText(R.styleable.TitleView_link) | |||
There was a problem hiding this comment.
I would rename it to link or linkText
| <com.google.android.material.textview.MaterialTextView | ||
| android:id="@+id/title_text" |
There was a problem hiding this comment.
Is this not too much indenting? Could you review your code style in AS?
There was a problem hiding this comment.
oh yes! solved 😄
|
📱 New catalog for testing generated: Download |
|
Seems to be a discrepancy between Classic and Compose:
Compose is the one that is aligned with the current design definition
I checked the buttonLink also, but it seems that in both scenarios the chevron is positioned correctly |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
🥅 What's the goal?
As figma definition title link could have chevron.
🚧 How do we do it?
☑️ Checks
🧪 How can I test this?
If it cannot be tested explain why.