ANDROID-14475 Subtitle color changed in lists #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
yamal-alm
approved these changes
May 28, 2024
pmartinbTEF
commented
May 28, 2024
| @@ -577,6 +579,7 @@ class ListRowView @JvmOverloads constructor( | |||
| private fun showNumericBadge(count: Int, withBadgeDescription: String?) { | |||
| Badge.removeBadge(badgeAnchor) | |||
| badgeAnchorContainer.visibility = View.VISIBLE | |||
| badgeAnchorContainer.setBackgroundColor(Color.Transparent.toArgb()) | |||
There was a problem hiding this comment.
If I don't add this line XML screenshots don't show badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Update color of subtitle in lists. Implementation of this PR #337
🚧 How do we do it?
Changed secondary color to primary color in lists (check screenshots). Added screenshot tests for XML and compose
☑️ Checks
🧪 How can I test this?
Before:
After: