Fix caption sizes not being changed

[Thompson3142]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

The caption size setting now correctly applies to the main player. I have tested this on several (emulated) devices, but additional test are probably needed to ensure it works correctly on all devices.
If I overlooked any aspects of the original implementation, I’m happy to adjust the code as needed.

Restarting the app is no longer required - only restarting the player is necessary. If this PR is accepted, the related strings in the settings should be updated to reflect this change.

Fixes the following issue(s)

• Fixes Changing caption size doesn't work #9702

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Profpatsch]

Looks like there is another place where this is set, in the Popup player:

NewPipe/app/src/main/java/org/schabi/newpipe/player/ui/PopupPlayerUi.java

Lines 426 to 430 in f7d0fd5

	protected void setupSubtitleView(final float captionScale) {
	final float captionRatio = (captionScale - 1.0f) / 5.0f + 1.0f;
	binding.subtitleView.setFractionalTextSize(
	SubtitleView.DEFAULT_TEXT_SIZE_FRACTION * captionRatio);
	}

[Profpatsch]

@Thompson3142 I adjusted the commit to include the Popup player, please take a look.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Thompson3142]

Doesn't that make the subtitles size in the Popup player extremly large? I doubt that anybody actually reads subtitles in the Popup player anyway but they should probably be smaller if somebody wants to read them.
On the other side I also don't get what final float captionRatio = (captionScale - 1.0f) / 5.0f + 1.0f; is exactly trying to achieve so if you have checked that the subtitles are readable its gtg.

[Profpatsch]

Doesn't that make the subtitles size in the Popup player extremly large?

It didn’t look like it. They had the same size as in the main player, and would shrink according to the resize. Although maybe a point could be made that they should stay at least the same size if you shrink the video, so you can still read them.

[Thompson3142]

You could spend months optimizing this for every possible screen size and caption size, but it’s not worth it. I’ve reviewed it myself, and the caption size in the popup seems appropriate (at least it is what I would expect it to be). I’m happy with this as is, making it a little more simple is definetly an improvement.