Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/modals #75

Merged
merged 18 commits into from
Mar 16, 2024
Merged

Feat/modals #75

merged 18 commits into from
Mar 16, 2024

Conversation

5ewon
Copy link
Member

@5ewon 5ewon commented Mar 16, 2024

Issue Number

#66

What

커스텀 alert, confirm, toastify 추가했습니다.

How

내용과 콜백 함수 지정이 가능한 alert를 구현하였습니다.

ScreenShot

image
image
image

Copy link
Member

@Ubinquitous Ubinquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

hideProgressBar
closeOnClick
pauseOnHover
closeButton={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closeButton 속성이 required한 속성이었나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 false로 지정안해주면 close버튼이 자동으로 생성됩니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 알려주셔서 감사합니다!!

id="image0_1403_145"
width="395"
height="395"
href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAYsAAAGLCAYAAAA24L6LAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAB7BSURBVHhe7d15kGVlecdxWYZhGBaBHhyIEBuEhhTLIA0IitC4EEWgZMcFDZhUI1j+gZJoaRCxRA0JsRLCWIaEGCwWFSO4JdG0pFRA22GNTLO2g8Ug0DMsAzPDwEx+z3mfHm/33L5L37O855zvp+qp531PKTQz955fv2fd7FVA+djndp7Xdt7nTtbA0PCt6oUaG1l8tNpLqjWqtV4vqlZ5X68CSoOwQMzmqHZS7aJaoOpTLVQYfEW9tBQkl6g9rXrS+1M+XqFapwKiQ1ggFvZZ3FG1u2pf1X4KhYvVa8WD5H7VUtVjqpWqDSqgUIQF8mSft21Vdrhoe4XBw7YRnVOY7KX2nMoOa9khLYIEuSAskLWdVbup9lDtroC4yjaidwqO89QeVT2uWqZ6VgVkgrBA2rZU7ee1SOHwSduI7Ck8LlW7T2WHsaxeVgGpICyQBrsCya76QYQUIlupceIcPSEs0K0tVJMnogcUEtfZRsRPoXGWNdUTKrsKiwBBxwgLdMrC4VDVgQqI2l2lVDUKDrvq6h7Vr1R21RXQEmGBVuYpGOwGMtSAAmQbtdVhBkxFWKCRXdL6WtU+CokfJFtQOwqNd6k9oLKbBe0yXYCwQPIZsMtbD1ANKiS+bBsBhcZFaqOqe1UTKu7pqDHCot7sBq/jFBBXhinQnILjfLXvq36bbEDtEBb1Ys9asiuZDlJA/FeyBZgFhYd9jl5QcUVVTRAW9bCDyg4zvVkhcVmyBeiRAuNCNbuayq6q4u7xiiMsqs1C4lgFxE1hCqRPoXGj2g2qn6gIjYoiLKppcwXEKz4GcqXwsBs3eV9HxWzuHeU3+Uym8wgKFMk/f/aQQ/s82nkyVAAri/LbWmUnrG8PUyAeWmXYneI/Ut2psseqo6QIi3KzZzPZS3KA6Ck4DlFbEmYoG8KifOyd069TSNgVKEDpKDQOVOMR6iVDWJSHPWb6AIWE3VELlJ5CY3+1B1UvJRsQNbtqAXGzixD2UV2goPhGsgWogL7+wY9MjCe/+zyi4hlUkWNlES87cb2rAsK+SEDlaaWxp9pyFS/SihCXzsbJvjQfIyhQJ/55/5jKPv+IDCuLuMxXDelLc0uYAvWjFcb1anbIdURlz59CBAiLeHAZLDCNgmNAzd6tgYJxgrtYdte1PSbc7rrm+U3ANH39gx+dGB+1S2ztmVN2EpzLbQvCyqI4C1RnKyQuD1MArWiV8Qm1a1RPJxuQK8KiGPba0jEfA+gCh6aKwdVQ+bFg3kN1DkEBzJ5/f85R7ZJsQC5YWeRjnspePMTb6YAUaZVxlNqvVauTDcgMJ7izt7vK7pn45zAFkJa+/sFzJsZH7d0Z96leTDYiE6wssmWPDr/LxwAypFXGIrW7wwxpY2WRjdeo/lJBcV2YAsiaVhnDWmXYi5eWqewy2w22HelgZZG+IxUSP/cxgAJolfEmtV+EGdLA1VDpsQf/nU5QAMXz7+GHVPa9RApYWfTO/gzfqA8nv8UAEdIq40g1e+0wh6V6wMqiN/Zby3EEBRAv/37aJbasMnrACe7Z20k1rA/iv4UpgFj19Q/+2cT4qJ30ttcR82a+WeAwVPfsz8wuib0zTAGUydjI4oPV7BJbDkt1gcNQ3bFl7LsJCqC8/Pv7bhWHpbrAYajOzVXZe7D/NUwBlFVf/+BZE+OjKzVcorJ7M9AGh6E6M1chwXuBgYoZG1l8idplqrXJBsyIsGhtjupgBcUdYQqgihQah6vZKoOXK82AcxatnURQANXn3/OTwgzNsLJozv5c3qMP0LfDFEAdaIVxitp3VFwpNQ0nuDe1o+pTCoorwxRAXfT1D54xMT5q+0V7WjTnKRsQFlPtqvprBcXHwxRA3Sgw3qLAmK+h3YvxfLIRhEWDharLFRQfDlMAdaXAOEyBYa8auE21KtlYc5yzCDfmDCgkeEkRgE2M8VKlBFdDhfdPEBQAmvL9w7FhVl91X1nwoiIAHdEKo9YvVKrrysJC8miCAkCnfH9xtKqWv2TXMSzsL9reaPfTMAWAzvh+4zRV7faddbsaakvVGfoLvy5MAaA7ff2Dp02Mjy7V0Gp9srEG6rScsqA4UUHBXdkAejY2svhUte+qavE8qbqsLOyBgGcpKK4PUwDojVYYp2uF8ZCG96sqv8KoQ1jYiuJMBcW/hykApEOB8R4FxoMa/kZV6cCo+mEoCwp7cuy3whQA0leHQ1JVPqNv/22nERQAsub7GbtKqrK/gFf1MNTk5bFc9QQgF339g6dMjI/a4SiryqlqCtoNd9xHASB3YyOLh9Qqt/+pYljwCA8Ahario0Gqds7iWIICQNF8P2QPH5ybbKiAKq0sDtJfEE+PBRANrTAq83jzqoTFQgXFch8DQDQUGPYGzifCrLyqcBjK/iL+JgwBIDq2f9otDMur7JfO7qiyd2bzKlQAUerrHzxwYnzUzl3crlqTbCyhMoeFHUL7lILi42EKAHFSYNg7vddpWNpLast8zuJkBQVPkAVQGmMji09RuynMyqWMYWFPkLXnPX0zTAGgPBQY9liQ/1CV6jlSZQyLwxQUd/gYAEpHgXG42i/DrBzKFhZzFRSlPUEEAJMUGFurrQ2z+JUpLAgKAJVSpsAoy30W9gd6fhgCQGVcoLL9W/TKsLKwQDteq4qbwxQAqkOrixPVvqfakGyIVBnCYpGC4k4fA0DlKDAOVov62Xaxh8V2CornfAwAlaXA6FObCLP4xHzOwo7jDYchAFTeOapoz1/EurKwn+sorSpuDVMAqD6tLt6p9p+q6M5fxBoWb1RQ3OZjAKgNBcYRavbQwajEGBZbKyhW+xjIlL6Yf642rlqpekZlx4xfVG2j2ln1apU93fh1+lx+TR3InD6X89Siuq8sxrD4oL6U1/gYSJ2+iB9Uu1/1sMpCopMlv31XLDT2Uu2tz+g3bCOQBX1GT1eL6vl3MYWFnWw/XF/CSr3kHPHQF9DeiXyPaoWql2PC9r2xlYc9p+x/ki1AyvR5PVItmsPxMYWFLfMf9TGQGn3pjlezk4avJBvSZe+EOU6f3e+HKZAefXYXqv0+zIoV06Wz7/cOpEJftK+o9tDwh6osgsLYP/eH9u9R/X3YBKQmmsccxbKyOEi/mUV99yLKRTvuz6l9SWUnq/Nih6Yu0mf54jAFeqfP8iK1u8OsODGExQJ9uZ70MdAzfbnOULO3kRXxchm7qepEfaZvCFOgd7ZyVXsszIpR9GEouzzso2EI9E5fqo+o2UMni3oLmV3ueLP/HEBa7BJv218WpuiwOES/gX3Gx0AarlUVfX26/fvt5wBS4fvJo1SFHQ0q8jDULvoDiOIsP6pBv83blUnrwywKm+szntWJddSQPuN/rLYszPJV5MrCLmcEUqEv0ZvVYgoKs14/12E+BtLwNu+5s9/EirCPfuP6sY+BnmiHfIWa3e0a4+spV0yMj87v6x+05/0APdHn6CR9nq7TMPdHmRexsrCrn8Z8DKTBzg/E+t4Tzl8gVb7/XBBm+ck7LOxs/tlhCPROqwq7SmSJKuZXUi7Rz/kXPgbSYPvRLcMwH3mHhT2A7XIfA2n4gffY8TgQpMb3o/1hlo+8w+IE70BalnuP3RPegbTYk2lzk2dY2Entz/sYSEvMh58axXalFkrO96f7hFn28gqL+X5SBkjN2Mji3L4oadDPu7cPgVT4fnV+mGUrr7AY8g6kKffLB3v0rHcgTbnsX/MIC3uz2HvDEEhV2e6Ofsk7kBqtLm5Rs9f/ZirrsLAncJ6q/5izwhRI1TrvZVG2nxflcbJqbhhmI+uw2FVB8UUfA2kr28qC50QhE9rPXq22W5hlI8uw2Ez/AY/4GMhC2Q7rsLJAZnx/m9nDYbMMC3tZB5ClPM65AWWS2RV3WX3ZtlKdG4ZAZnJ93EEK5ngHsvJ+le1/U5dVWLxeSyJeaoSslS0sinrKM2rC97v7h1m6sgiLLfUD/5+PgSyV7Td1VhbInPa/v1bbLszSk0VY7OsdyFrZdr6ZHB4AmrA36qUq9bBQqt3rQyBrO3svi528A5nKYj+cdli8wTuQOX0h7vdhKejnXepDIA+pPjstzbDY2o+VAXkqy0ljTm4jV9of20MG7SkaqUgzLBZ5B/L0Ou+xy/VFNYBLbb+cVljYicY/DUMgV/bcsczuWk2J/XxnhiGQH60ublNL5RLztMLC7qu42MdAbvS5u1TtaFWsgWE/19H+cwJFSOWu7rTCgvdVoEj2esntwzA69nPl+vpLYJpjvPckjd/GNtdvTTxNE4UaG1lsq4v/DbOoHKXvR4w/F2pE3w+7wKKnV/v2HBb6IpTlHcioOH0h7EakZWEWhT30/fitj4FC6fvR0/6+18NQO3gHCuc75lhu1NuZoEBketpf9xoWb/UOxOLDqtSuLZ+lbVX2cwAx6Wl/3cuyxFLqq/rt6YwwBeKhJfcuak+FWa4WqD6g78XfhikQD30v7F3dz4ZZd3pZWRxAUCBW+mw+qZbZi2BmYP++LxIUiNgB3rs227Cwm/DeHIZAtK5QHaZK46q/Vuyfb/+eKxQU5yRbgDjZfntWN+nN9kv0an0pVvoYiJqW3h9Su1aVxSXe9v4W3q2N0tD34TVqtvLuyqxWFgQFykSf12tUL2t4tsreDd/rhR32/7d/ztkEBUroQO9dmdXKQl8Q7q1Aaek3q0+qLVHdp1qu6uTzbN+VXVX2ysqD9R34om0Eykjfga73/bMJC240QmXoS/NVNQsOC40nVI+pnlPZYzr+SLVQtZvqQH3uL1AHSk+f+73UHgmzznQbFva/P09fmivDFABQNgoL+8Xnn1QdHyXqNiz6FBRFXLsOAEiRAsPuCXo6zNrr9kTfrK/RBQBEpav9eTdhYcdwDwlDAEDJ2f58qzBsr5vDUHsNDA0/5GMAQMmNjSx+vdrDYdZaNyuLAe8AgGrYx3tbHa8stKrg3goAqBitLjrKgU5XFvO8AwCqpaP9e0eJwqoCAKqrk9VFt5fOAgBqqJOw2N07AKCaXut9Rp2ExaHeAQDVZO9jaaldWNhLjmb1OFsAQGnYfn6LMGyu3UmNXQeGhh/3MQCgoto9K6rdysIezwwAqL6W5y3ahQV3bQNAPezrvamWh6G4vwIA6qPV/RatVhZ2chsAUB9zvW9ixhRhVQEA9TPT6qKT+ywAADU3U1i0vN4WAFBZW3qfYqaw+BPvAIB62c/7FDOFRdP/MQCg8roKi/29AwDqZZH3KZqd9d5hYGj4GR8D0er0DV8x4SpDlIG+W31qE2EWNFtZ7OEdAFBPu3nfqFlYbPI/AgDUyiaLhulhYfP+MAQA1JS99G7KYd7pYTF/YGj4Kh8DAGrIc2DbMAumh8WMzwUBANTKlDyYHhbbewcA1Nt23hNTwkJLj4d9CACoMeXBIz5MTF9ZAACwCcICANBWY1iU7m5YAECmNuZCY1i82jsAAGZH71PCgsd8AAAa2c15icaw2Nc7AABmYy4QFgCAmWwSFnMGhoY/62MAAOxeC8uFOTaeDIudvAMA0CjJh8mw2MU7AACNknyYDIsF3gEAaJTkw2RY2Cv0AACYLsmHybBY6B0AgEZJPlhYWHGCGwDQjOXDZhYU2wwMDV+cbAIAoIHnwzwLiymvzgMAYJokLLYJYwAAmtrOwoL3bgMAWklWFoQFAKCVuRYWW4cxAABNJWGxVRgDANDU3M0HhoZv9QkAAJuwnLCVBQAALREWAIC2CAsAQFuEBQCgLcICANAWYQEAaIuwAAC0RVgAANoiLAAAbREWAIC2CAsAQFuEBQCgLcICANAWYQEAaIuwAAC0RVgAANoiLAAAbREWAIC2CAsAQFuEBQCgLcICANAWYQEAaIuwAAC0RVgAANoiLAAAbREWAIC2CAsAQFuEBQCgLcICANAWYQEAaIuwAAC0RVgAANrafGxk8dE+BgBgE5YTtrJ4KUwBAGhqrYXFmjAGAKCpJCzWhjEAAE0lYbE6jAEAaCoJi1VhDABAUy9aWLwYxgAANLUqOQw1NrL4kjAHAOAPPB9WW1hsUD1tGwEAmMby4RULC/OkdwAAGiX5MBkWrCwAAM0k+TAZFk95BwCgUZIPHIYCALQy5TDUCu8AADRK8mEyLNZx+SwAoJHnwjobT4aFud87AABmYy40hsVS7wAAmI250BgWy7wDAGAe8z4lLJ71DgCAWel9Slis9w4AgLHHQSUawwIAgKYICwBAW1PCYmxk8V4+BADUmPJgTx8mpq8snvMOAKi3570npofFWu8AgHqbkgfTw+IFLT3O8zEAoIY8B1aFWTA9LOzy2Y03YQAAaulR1cbLZs30sDDcyQ0A9fa4942ahcUm/yMAQK1scoSpWVhMjI0svszHAIAa0f7/UrVnwuwPmoWFucs7AKBe7vM+xUxhwbstAKCemu7/ZwqL33gHANRLV2HxincAQL287H2KmcICAICNZgyLsZHFW/sQAFAD2u9v5cNNtFpZ8JwoAKiXdd430fIwlFLmLB8CACqs3f6+3TmLMe8AgGprub9vFxa/8w4AqLYnvDfVLixWaGlyiY8BABXk+/mnw6y5dmFh91vcE4YAgIqy/fyMJ7dNu7Awv/QOAKimtvv5TsKC8xYAUG1t9/OdhAUAoOY6CouxkcXb+BAAUCGd7t87XVms9g4AqJaO9u8dH4ZS+hzvQwBABWi//i4fttXNOYsHvAMAqqHj/Xo3YbFMKXSRjwEAJeb78yfDrL1uwuIl1WgYAgBKzvbnz4dhe92EhbnXOwCg3Lp6Oke3YTGhpcv5PgYAlJD24xeorQizznQbFhtUPwpDAEBJ3aKy/XnHug0L84h3AEA5LfPesdmEhS1h3uFDAEANzCos5G7vAIAS0S/7O/qwK7MNi5X6F17oYwBACfh+e1WYdWe2YWEvyeA9FwBQLrbffjkMuzPbsDDccwEAJaFVxY1qs95v9xIWz+pffoqPAQBxu0H1bBh2r5ewMD/xDgCIW0/7617DYtYpBQDIVU/7617Dwo6D9fzPAABkR/vpLXw4a2ns6DfoB+F5UQAQIe2fP6K2PsxmL61VwYh3AEBcfuq9J2mFxYPeAQCR0KriErWHw6w3aYXFy/qhjvAxACAO9pRwe3Fdz9I8OX2XdwBAHFLbL6cZFmu0utjXxwCAAml/fIjamjDrXZphYca8AwCKtcR7KtIOC0uzA3wIAChAFvvh1MNCxr0DAIqx1HtqsgiLVX6sDACQM+1/91eb1WPIW8kiLMx9+oEv9TEAIAe+383kvreswsKu6/1GGAIAcnK1KpX7KqbLKizMA94BAPlY5j11WYaFPWBwTx8DADLk+9sNYZa+LMPCLNd/wF/5GACQAe1nz1Z7PMyykXVY2N2D3wxDAEDaFBTXq9mTZdcmGzKSdViYR/Qfc4KPAQDpsouJHgvD7OQRFob3XQBANnLZv+YVFi9odTHgYwBACny/+kKYZSuvsDAP6D/s0z4GAPTA96e53aKQZ1iYG70DAHpzs/dc5B0WjyoNP+5jAMAs+H70oTDLR95hYQ+3+noYAgBmyfajq8MwH3mHhXnKT8oAALrk+8+nwiw/RYSFsZPd5/oYANAB328W8ty9osLC/Ng7AKAz3/OeuyLDYplS8h0+BgC0oP3lUWpPhln+igwL8zP9AfCSJABowfeTvw6zYhQdFnY2/2thCACYwT+ocr36abqiw8I8ptRc5GMAQAPfP+Z+9dN0MYSFuZvDUQAwlfaLn1G7O8yKFUtYmCu9AwACe/x4FGIKi98rRY/0MQDUmu8PfxtmxYspLMxt+gM63ccAUEvaD35I7TbV+mRDBGILC3OLdwCoqxu8R2Mz77E5YmBo+Bc+BoDa8MNPtqqISowrC3OH/sDe6WMAqAXt945Ruz3M4rKF99hsUP1uYnz0ub7+wbeHTQBQXQqKi9RuUtmrHKIT68rCrFFdHYYAUHlXqWy/F6WYw8KsUNoe7GMAqCTfz60KszjFHhbmHv1BnuhjAKgU379FcZd2K7Ges2hk5y+WTYyPruzrHzwubAKA8lNQ2Lu0r1dFeZ6iURnCwtgf5BIFxgsKjLeFTQBQXgqKS9T+TrU22RC5MhyGmmR/oFeEIQCU3mWqUgSFKVNYmLVK48N9DACl5Pux0gSFKVtYmDv1B32qjwGgVHz/dWeYlUesj/voxMkDQ8Pf9jEARE9BcYqa3XhXOmU5wd3M0onx0S36+gff4nMAiJaC4vNqduNdKZU5LMxdCoz5CozDfA4A0VFQ/KPaF1SFvke7F2U8Z9Fopcr+AgAgSgoKe9udXflk+6vSKntYmOX6y9jVxwAQG7vx7vEwLK8qhIV5QoGxyMcAEAXfLz0RZuVWlbAwY/qLeauPAaBQvj+K/plPnSrzpbMzOXJgaPjnPgaA3Cko3qRWqbd9VmllMekX+ouyt00BQO60/xlSq9xroasYFuZW/YWd4WMAyIXvd24Ns2op+30Wrdw/MT461tc/aHdMAkCmFBTvVfumyl6rUDlVPGfRaEvVSQNDw98KUwBIn4LCnvf0XVX076WYrSqvLMx61YNaYTykFcZ7wiYASI+C4mw1+4W0skFhqh4WxgLDDkk9SGAASJMHRSnedNerqh+GamSHpE7kSbUA0lCHQ0+N6rCymDR5SGopJ70B9EJBcZbad1S1CApTp5XFJLtc+FStMG4IUwDonILCLo+t7FVPM6ljWEw6RoEx4mMAaEtBYTfc2X0UtQoKU+ewMDwaBEBHFBSVe4RHN6p6B3en7NEgPHwQQEu+n6htUJi6rywmHaQVxl0+BoCNFBT2mPEx1ZpkQ00RFn+wUHW5QuN9YQqgzhQS16p9QlWJ91H0qk6XzrazSnXbxPjoXN7pDdSbgsLemX2xanmyAYTFNBYYtysw1ikw3hI2AagTBcXn1ezd/k8lG5DgMNTMTh7gbm+gVhQUdsPuTWGGRnW/GqqVm/TBOc3HACpO33d7fAdBMQNWFq3NUR2sFcYdYQqgihQUh6vdqVqXbMAmCIvOzFVg1PqyOaCKFBKfVLtCtTbZgBkRFp2bq7pAoXF5mAIoMwXFhWpXqgiKDhAW3dla9XYFxs1hCqCMFBQnqv23iiMGHSIsumd/ZnbHtx3fBFAyCgq7I/seVe0eBtgLwmL2tlMNKzS+HKYAYqaQuEjtX1QTyQZ0hbDozTzVYQqMn4YpgBgpKN6lZt/T1ckGdI2w6J3dq3K4AqPWT6QEYqWgOELNLn/nsFMPCIv02MnvMxQa14QpgCIpJE5Xu0XFSewUEBbp44VKQMEUFLV+UVEWCIv02cMZd1d9QKHxuWQLgFwoJC5Vs3snfp9sQGoIi2zxUiUgJwoKuyT27jBD2giL7C1QfVSh8ZkwBZAmX018TfVYsgGZICzyYZfYvkGB8bMwBZAGBcU71Ox7xSWxGSMs8rWL6t0KjavDFMBsKCTOVfuxylYTXBKbA8KiGAMKjKU+BtAFBcW+1sIMeSEsimPnMs5WaPAUW6ADColPqNl9TE8nG5ArwqJYdi5jb9UJCg177y+AaRQSn1a7UfWo6mXbhvwRFvHYR4HB0hpooKAYUHsgzFAkwiIu81VDqvcpOM5MtgA1pJA4QW1E9UKyAYUjLOJkd4Afo8D4epgC9aCQOEftO6pnkg2IBmERL3sw4a4KjEfCFKg2BcWeastVPPgvQoRF/OwR6LbSOFfBwV3gqBQFhN19fa3qQRX3S0SMsCiPrVR7KzDuC1Og3BQUg2r3ql5KNiBqhEX5bKnaT6Fh7xAGSkchcaDauOr5ZANKgbAot4MVGkt8DERNIcFlsCVGWJSfnQg/SPVOBcfFyRYgIgoJe63pnaq1yQaUEmFRHXZOYy/VkELDXv4CFEYBcb6a3SdhJ66567oCCItq2kyBsd7HQK4UFPa2SD5/FUNYVNsOqmNVZyo87OX1QCYUEKeo/UT1bLIBlUNY1IOFxgGqoxQaX0i2AD1SQFyo9iuVXZlHSFQcYVEvdtnttgqMlWEKzI6C4jVqK1Scj6gJwqLe9lDZm/s4IY6W/IT1j1Q8fqamCAvYZ2Bn1f6qQxUcX7aNgALiIrVRld1lPaHicRw1Rlig0XYqO7xg79b4frIFtaOQON6ayt5vzaM4kCAs0Mo8hcaLPkbFKSS2UVsdZsBUhAU6ZU++PVR1oAKEO8VLTsFwiZpdxWRXM9kKAmiJsEC35qj6VHa4al8Fx3W2EfFTQJxlTfU7lV3J9IoK6AhhgTTMUWhwbDtSCgl7fhjPZUJPCAukLXmEutf+ChFe2JQThcJlanep7vfiHgikhrBA1uzucbufYzdVv8LjKtuI3ikczlOz8w3LVI+r7PJWIBOEBfJkr4idr5qr2l7B8bBtROcUEPZk4edUdljpBRUP7EMuCAvEwj6LO6psFWIvybGT559VrxWFgV2lZIeQ7ES0rRjs0SzcDIfCERaImV15tZNqF9UClV2FtVAh8hX10vJAeFr1pPenfGxXKK1TAdEhLFBG9r6EeaptVXYjmR3W2lgKk1vVC6VAOFrNrhBbo7JDRnaz2yqV3eRoY1YLKJFXver/Ad3/5+W9eSdaAAAAAElFTkSuQmCC"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???????멉니까익[

Comment on lines 7 to 11
interface Props {
content: string;
}

const Notice = ({ content }: Props) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간단한 props는 { content } : { content: string }과같은 형식으로 나타내는건 어떠신가요?

Comment on lines 10 to 11
backgroundColor: "#ececec50",
zIndex: "11",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zIndex를 10단위로 주시는건 어떻게 생각하시나요?
그리고 backgroundColor또한 theme에 넣어서 사용하면 더욱 유지보수에 도움될 것 같습니다!\

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 어쩐지 다른 css파일에서 zIndex가 10단위다 싶었는데 듣고보니 10단위로 주는 것이 보기에도 깔끔하고 추후에 다른 컴포넌트가 추가되었을때도 문제가 덜할 것 같네요. 두가지 다 반영하겠습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다 !!

Comment on lines 21 to 23
display: "flex",
justifyContent: "center",
alignItems: "center",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flexGenerator를 사용해서 ...flex.CENTER를 사용하는것도 좋을 것 같습니다!

Comment on lines 1 to 8
import { atom } from "jotai";
import ModalState from "../type/ModalState.type";

const modalContext = atom<ModalState>({
component: null,
});

export default modalContext;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달context를 따로뺴지않고 context 디렉터리에 export로 추가하는건어떨까요?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달 훅은 따로뺴지않고 hooks 디렉터리에 따로 추가하는건 어떨까요?
bsm의경우 도메인이 너무 커 따로 뺐었지만 부마위키는 그럴 필요성은 없어보입니다!

Comment on lines 10 to 12
({ component }: ModalState) => {
setModal({ component });
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

({ component}: ModalState) => setModal({ component })는 어떠신가요?

const Modal = () => {
const modal = useAtomValue(modalContext);

return <div>{modal.component}</div>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div대신 fragment를 사용하는건어떠신가요?

@@ -0,0 +1,3 @@
export default interface ModalState {
component: React.ReactNode;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

부마위키 컨벤션에서는 React.을 사용하지않고있습니다!
또 type을 따로빼지않고 types 디렉터리에 넣는건어떠신가요?

@5ewon 5ewon merged commit 6d582f0 into main Mar 16, 2024
1 check failed
@Ubinquitous Ubinquitous deleted the feat/modals branch November 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants