ScrollButton 컴포넌트 퍼블리싱 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ewon
approved these changes
Mar 11, 2024
| <button | ||
| className={styles.scrollButton} | ||
| onClick={scrollToTop} | ||
| aria-label="최상단으로 올라가기" |
There was a problem hiding this comment.
기존에 없던 레이블이 생겼네요. 웹 접근성 개선 차원에서 작성하신걸로 보입니다. aria-label 대신 aria-description을 사용하는것에 대해서는 어떻게 생각하세요?
There was a problem hiding this comment.
aria와 관련된 속성은 JSX에서 대쉬바로 props를 전달해주어도 문제가없나요??
There was a problem hiding this comment.
button에 text가 없으면 eslint 에러가 떠서 aria-label로 작성하였습니다.
aria와 관련된 속성은 jsx에서 kebab case로 사용합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close #35
What
스크롤버튼 컴포넌트를 퍼블리싱하고, 기능 구현을 하였습니다.
How
ScreenShot