Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/hook loop #41

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Bugfix/hook loop #41

wants to merge 2 commits into from

Conversation

tvanlaerhoven
Copy link
Member

On Safari browsers, the useCurrentTime hook would throw a Error: Maximum update depth exceeded. The result of getSnapshot should be cached to avoid an infinite loop. error, because the getSnapshot result would differ from store result.
Replaced the useSyncExternalStore hook with useState.

@MattiasBuelens
Copy link
Contributor

Interesting. Should we port this to Open Video UI for React too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvanhaevre wvanhaevre Awaiting requested review from wvanhaevre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvanlaerhoven @MattiasBuelens