Add to sirf classes #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: copy, conjugate closes Hackathon-SIRF/#7
notice that it's not taking into consideration #2 (comment)
for MR images dot operator calculates the inner product with conjugate by itself.
changed AcquisitionModel to inherit from object.
closes #7
|
@paskino, any reason why this isn't a PR to the main repo? |
|
I believe Matthias and I were busy trying to tidy up also the other bits of integration of cil/sirf. I guess I should do that. |
evgueni-ovtchinnikov
approved these changes
Nov 14, 2018
evgueni-ovtchinnikov
approved these changes
Nov 14, 2018
evgueni-ovtchinnikov
approved these changes
Nov 14, 2018
evgueni-ovtchinnikov
requested changes
Nov 14, 2018
| @@ -150,6 +150,19 @@ def main(): | |||
|
|
|||
| back_projected_image_as_array = back_projected_image.as_array() | |||
| show_2D_array('Backprojection', back_projected_image_as_array[z,:,:]) | |||
|
|
|||
| acq_model.direct(image, 0, 4, simulated_data) | |||
| # simulated_data = acq_model.forward(image, 0, 4) | |||
There was a problem hiding this comment.
lines 155-157 are not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress