Move to Gradle, fix package names, reduce jar size #54
+397
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get Maven to work. It just threw random, impossible-to-debug errors which made 0 sense whatsoever. Moving to gradle made everything work AND gradle builds are faster. - Fix package names - Update plotsquared dependency Signed-off-by: AlessioGr <[email protected]>
Signed-off-by: AlessioGr <[email protected]>
Signed-off-by: AlessioGr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have spent 6 hours trying to build this plugin in Maven, but it failed every time because of seemingly random errors which made no sense. Thus, I switched it over to gradle, and it worked just fine.
This decreases the final size of the jar by 30kb (for some reason, the source was included in the last one) and it makes builds a lot faster.
The plotsquared dependency was updated as well.
I have also corrected the package names. They were all lowercase, which did not compile for me.