Vehicles Support, PlotSquare API update and Material FIX #31
Conversation
| @@ -172,7 +172,7 @@ void setName(Player p, ArmorStand as) { | |||
| p.sendMessage(ChatColor.RED + Config.noAirError); | |||
| return; | |||
| } | |||
| b.setType(Material.SIGN); | |||
| b.setType(Material.OAK_WALL_SIGN); | |||
There was a problem hiding this comment.
SIGN_POST isn't a Material in 1.15 API.
Maybe the Material would be OAK_SIGN.
I'm not sure how that part is supposed to work.
However if the plugin is intended to be compiled in 1.13 just remove that part before merging.
There was a problem hiding this comment.
From what I understand is the method(s) used with this used for things like renaming the armor stand or adding a Player head.
In that case does AST "summon" a Sign which is "opened" for the player to then input the text.
And it was always a standing sign. I'm not sure if a wall sign would change this dramatically, but I would leave it as a standing sign for consistency.
There was a problem hiding this comment.
I checked and it works the same. However I just changed it from OAK_WALL_SIGN to OAK_SIGN
| @@ -184,7 +184,7 @@ void setPlayerSkull(Player p, ArmorStand as) { | |||
| p.sendMessage(ChatColor.RED + Config.noAirError); | |||
| return; | |||
| } | |||
| b.setType(Material.SIGN); | |||
| b.setType(Material.OAK_WALL_SIGN); | |||
|
@pollitoyeye Wouldn't it be better to have a downloadable, public API, rather than requiring to have the Jar available? |
|
Do you know any program that generates an API Jar? |
|
there exists jitpack.io which would allow you to share a GitHub repository like an API for maven/gradle. |
|
Okay, I found a project called JstubGenerator to do this. |
|
@St3venAU Will this ever be merged/looked into? |
St3venAU, please contact me on Spigot via DM after accepting this so I can give you a free copy of the Vehicles plugin (So you can compile the plugin).