Support Scala 2.13 #62
Conversation
|
@jhnsmth could you please try to get this into form where every other project than kafka compiles under 2.13? so that we are ready as we can be. |
|
@AdamChlupacek sry, couldn't find some time. I hope to do it tomorrow |
|
@jhnsmth This seems nearly finished now? Seems that tests are passing, weird that we do not see an issue with kafka anywhere. |
|
@AdamChlupacek Sorry, for the delay. Yes, it should be finished now. But unfortunately there are some deprecation warnings on 2.13 related to the new collections api, so fatal warnings is turned off, is it ok for now ? |
|
@jhnsmth Sorry for such late response, been quite busy lately. I would prefer not to turn off fatal warnings, as we are depending on them, especially since they only appear when you are recompiling the given file, as such with incremental compilation it is quite hard to maintain code for production uses as this can hide some important errors. |
|
@AdamChlupacek sry, for a long reply. I'm afraid it's not simple to enable fatal warnings for 2.13. Because of the deprecations in scala standard library. So it requires either adding dependency on https://github.com/scala/scala-collection-compat and rewriting using new syntax or breaking binary compatibility. Here is one of the examples. If I'm wrong please correct me. I've added a commit that enables them for scala version below 2.13. But I'm open to any other suggestions |
|
A possible solution to allow fatal warnings to be turned on for all Scala versions https://github.com/guymers/protocol/commit/00ebbb5e91765b849cce0e645ceeb971720fc85b |
|
@AdamChlupacek I'll do it late tonight or tomorrow. |
|
I do not mind. Looking forward to seeing Scala 2.13 support, thank you for creating this PR. If you don't mind though could you please fix the commit message: |
Add a `RightBiasedEither` implicit class for use by Scala 2.11 Replace `mapValues` with `map` to avoid Scala 2.13 deprecation warnings Use `linesWithSeparators` over `lines` and `linesIterator` due to `lines` being deprecated in 2.13 and `linesIterator` being deprecated in 2.11
|
All done! Ready for a final review! |
|
Can this be merged to unblock Spinoco/fs2-http#37 ? |
|
@jhnsmth Any chance that, while the maintainers of fs2-http don't have 2.13 support merged in, you can publish 2.13 artifacts under your own organization so that projects can work on being migrated to 2.13? |
|
Sorry for such a delay with this guys, i will get this out asap. |
|
So i tried to do the release, but it would seem we need to have all the cross builds in the main aggregating file, as such we need to get the kafka protocol to be building for 2.13, I will get a stab at it today. |
Unfortunately, I didn't notice that kafka isn't yet published for 2.13 and according to their JIRA it scheduled for 2.4.0, so we should not expect to get it pretty soon.
I'll try to setup some cross-build stuff in a couple of days.