SONAR-23714 Deprecate account in favor of setAdminPassword #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carminevassallo
force-pushed
the
task/cv/SONAR-23714-deprecate-account-in-favor-of-set-admin-password
branch
4 times, most recently
from
551f4e6 to
666731d
Compare
jCOTINEAU
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Should we modify the tests change-admin-password-hook-values.yaml and put there the entire new structure? i would expect no changes from the fixture point of view, which would indicate a successful transfer of logic ? maybe also keeping a test file with the legacy account?
Wdyt ?
carminevassallo
force-pushed
the
task/cv/SONAR-23714-deprecate-account-in-favor-of-set-admin-password
branch
from
ecd9dad to
5c67a66
Compare
|
carminevassallo
deleted the
task/cv/SONAR-23714-deprecate-account-in-favor-of-set-admin-password
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.