Remove duplicated parameters from README #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased with main and fixed merge conflicts |
jCOTINEAU
requested changes
Feb 28, 2024
update the changelog update chart.yaml
|
The commit has been reworded to start with |
jCOTINEAU
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
CHANGELOG.mdfile of the respected chart as well as theChart.yamlHello,
When setting up my own SonarQube DCE instance I noticed that the
ApplicationNodes.resourcesparameters were duplicated in the README. In addition to where I removed they can also be found at lines 258-261, hence I removed the later section to prevent confusion for more users down the line.