Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONAR-21708 implement google cloud k8s sonarqube app #428

Merged
merged 3 commits into from
Feb 27, 2024
Merged

SONAR-21708 implement google cloud k8s sonarqube app #428

merged 3 commits into from
Feb 27, 2024

Conversation

jCOTINEAU
Copy link
Collaborator

No description provided.

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21708-implement-google-cloud-k8s-sonarqube-app branch 4 times, most recently from 3a3a055 to bc8491b Compare February 22, 2024 18:09
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21708-implement-google-cloud-k8s-sonarqube-app branch 3 times, most recently from 5083e1e to 11ad0b2 Compare February 26, 2024 10:34
carminevassallo
carminevassallo requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both install and verify work well. The PR is ready to be merged, just a few minor changes/questions.

google-cloud-marketplace-k8s-app/schema.yaml Outdated Show resolved Hide resolved
charts/sonarqube-dce/templates/application.yml Outdated Show resolved Hide resolved
tests/unit-compatibility-test/sonarqube-dce/application-values.yaml Outdated Show resolved Hide resolved
google-cloud-marketplace-k8s-app/README.md Show resolved Hide resolved
google-cloud-marketplace-k8s-app/README.md Show resolved Hide resolved
charts/sonarqube-dce/templates/application.yml Show resolved Hide resolved
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21708-implement-google-cloud-k8s-sonarqube-app branch from 15e76be to 438f71b Compare February 27, 2024 10:23
carminevassallo
carminevassallo approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small reminder about not squashing all into one commit but keeping two, as you were addressing two tasks...

@carminevassallo
Copy link
Collaborator

Hey @davividal, could you please review it too? There are requested changes that prevent this from being merged...

@jCOTINEAU
SONAR-21708 implement google cloud k8s sonarqube app
eff6da1
@jCOTINEAU
SONAR-21727 implement mpdev verify tests command
9d42eb5 
NO-JIRA temporary fix missing application crd in test

waiting for datreeio/CRDs-catalog#276 merge

update partner name and partner id

update partner id and fix tests
@jCOTINEAU
SONAR-21728 add elasticsearch kernel requirements
362205d 
resolve comment and run linter

add elasticsearch parameters to schema.yaml
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21708-implement-google-cloud-k8s-sonarqube-app branch from 438f71b to 362205d Compare February 27, 2024 16:08
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jCOTINEAU jCOTINEAU changed the title DRAFT SONAR-21708 implement google cloud k8s sonarqube app SONAR-21708 implement google cloud k8s sonarqube app Feb 27, 2024
@jCOTINEAU jCOTINEAU requested a review from davividal February 27, 2024 16:18
davividal
davividal requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@davividal davividal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment on the compatibility test. Other than that, LGTM.

.cirrus/unit_helm_compatibility_test.sh Show resolved Hide resolved
@jCOTINEAU jCOTINEAU merged commit 31ae79d into master Feb 27, 2024
7 checks passed
@jCOTINEAU jCOTINEAU deleted the feature/jc/SONAR-21708-implement-google-cloud-k8s-sonarqube-app branch February 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davividal davividal davividal approved these changes

@carminevassallo carminevassallo carminevassallo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jCOTINEAU @carminevassallo @davividal