-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONAR-21408 run static test in PR #410
SONAR-21408 run static test in PR #410
Conversation
d95acc5
to
f589ccf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jCOTINEAU is there a specific reason for running the static test in GH Actions rather than Cirrus?
@carminevassallo, comfort mostly as we already had a similar behavior for next scan with our GitHub_action, so it was very quick to implement. This is a very small baby step in my opinion. |
Given that we are trying to use one CI system, would that be better to spend a little bit more time but implement the step in Cirrus? |
3d17fc2
to
fd171ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for refactoring your previous change! I think we could add another small improvement that will be useful for the other tasks too. As of now, in our CI, we don't test against a specific version of k8s.
How about we add an ENV fixing the k8s version (e.g., KUBE_VERSION
) that we use to execute the static tests and to create the kind cluster (in the wait_for_kind
script we don't specify the k8s version)?
p.s.
I also suggest that we rename the task into "static_compatibility_test"
fd171ff
to
a37e57d
Compare
a37e57d
to
1491a3e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 💯
No description provided.