trim whitespace from EOLs when line split is found #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batwomankt
commented
Mar 16, 2024
| @@ -1328,6 +1328,9 @@ public TextLine SplitAt(LineBreak lineBreak, bool keepAll) | |||
|
|
|||
| if (index == 0) | |||
| { | |||
| // Now trim trailing whitespace from this line in the case of an exact | |||
| // length line break (non CJK) | |||
| this.TrimTrailingWhitespaceAndRecalculateMetrics(); | |||
There was a problem hiding this comment.
I found that in case of exact length line breaks, there could be whitespace that remains untrimmed - the addition of this line here would take care of that (without losing the benefits of the fix added for issue 367)
JimBobSquarePants
previously approved these changes
Mar 19, 2024
Yeah, I had missed one final spot above where whitespace needed the extra trimming! |
JimBobSquarePants
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
In
SplitAt, when aTextLineis split at exact length match - the loop will no longer grab and trim the whitespace on the next iteration because it exits early (Issue 367 fix). Instead, added a whitespace trim inSplitAtwhen the exact length match is being examined.See Issue 393 for a visual representation. More detail can be provided upon request.