-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed outdated sqlalchemy databricks #696
removed outdated sqlalchemy databricks #696
Conversation
WalkthroughThe recent changes primarily focus on introducing a new attribute Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- poetry.lock
- pyproject.toml
Files selected for processing (6)
- docs/connectors.md (1 hunks)
- examples/from_databricks.py (1 hunks)
- pandasai/connectors/base.py (1 hunks)
- pandasai/connectors/databricks.py (1 hunks)
- pandasai/helpers/openai_info.py (1 hunks)
- tests/connectors/test_databricks.py (1 hunks)
Files skipped from review due to trivial changes (5)
- docs/connectors.md
- examples/from_databricks.py
- pandasai/connectors/base.py
- pandasai/connectors/databricks.py
- pandasai/helpers/openai_info.py
Additional comments: 1
tests/connectors/test_databricks.py (1)
- 24-29: The addition of the "catalog" parameter to the
DatabricksConnectorConfig
instance is consistent with the changes described in the pull request summary. Ensure that all calls to this function throughout the codebase have been updated to match the new signature.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 85.37% 85.38%
=======================================
Files 70 70
Lines 3481 3482 +1
=======================================
+ Hits 2972 2973 +1
Misses 509 509
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- poetry.lock
- pyproject.toml
Files selected for processing (2)
- pandasai/connectors/base.py (1 hunks)
- pandasai/helpers/openai_info.py (1 hunks)
Files skipped from review due to trivial changes (1)
- pandasai/connectors/base.py
Additional comments: 1
pandasai/helpers/openai_info.py (1)
- 74-83: The logic for checking the model name and appending "-finetuned" or "-completion" seems fine. However, it's important to ensure that the model names being checked here are consistent with the ones in the
MODEL_COST_PER_1K_TOKENS
dictionary. If there are any discrepancies, it could lead to unexpected behavior or errors.
Is this blocked by anything, or can it be merged? |
@Josha91 the only blocker is it needs to be tested extensively, we can't risk to add regressions. Will test it out asap (if you also want / have the chance to give it a try, it would be awesome) :) |
Replaced old
sqlalchemy-databricks
withdatabricks-sql-connector[sqlalchemy]
but still python SDK provided by databricks doesn't support integration with pandas. Beacuse pandas only support sqlalchemy at this time.As per official repo ,
databricks-sql-connector[sqlalchemy]
exposes a SQLAlchemy dialect for use with tools like pandas.Summary by CodeRabbit
standardize_model_name
function in the OpenAI helper module by reorganizing the condition checks.QueryBuilder().dict()
function call in the Databricks connector tests to include the new "catalog" parameter.