Fix UDS socket configuration and improve error handling #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were not passing the correct value from the environment in the constructor Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
feat/too-big-package-uds
branch
2 times, most recently
from
38ce5c2 to
979c53c
Compare
Signed-off-by: Pedro Tanaka <[email protected]> fixing ci Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
feat/too-big-package-uds
branch
from
979c53c to
fea344d
Compare
pedro-stanaka
changed the title
Signed-off-by: Pedro Tanaka <[email protected]>
ahayworth
approved these changes
Dec 18, 2024
Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
pedro-stanaka
force-pushed
the
feat/too-big-package-uds
branch
from
25c72b4 to
5ed58a3
Compare
Signed-off-by: Pedro Tanaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ What
Problem
When using Unix Domain Sockets (UDS) with statsd-instrument, the
max_packet_sizeconfiguration wasn't being properly passed through from the environment to the UDS connection. Additionally, error handling and debugging information for socket errors needed improvement.What was done
Environment#default_sink_for_environmentmethod to properly passmax_packet_sizeto both UDS and UDP connectionsNotes
When using UDS with aggregation, be aware that the OS might impose its own limits on datagram sizes. The socket buffer size can be configured, but there might still be per-message size limits that can't be exceeded.
🤔 Why
The send buffer should match the max_packet size on the BatchedSink, otherwise messages will be dropped.
👩🔬 How to validate
Added tests for the behavior.
Checklist
#gsd:41649