Build up to the Prisma adapter with turbo #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
build_prisma_with_turbo
branch
from
651b1ed to
1a0c6ef
Compare
paulomarg
commented
Mar 27, 2024
There was a problem hiding this comment.
This is mostly copying the file from its previous location in the session-storage package since this will apply to basically everything.
sle-c
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The changes in #707 allowed us to start building packages with turbo in this repo. Following that, we'll need to get all of the packages building with the new process.
As a first step, this PR is changing all of the packages needed to build the Prisma session adapter to use turbo, and making the configurations for rollup a little more generic since most of it will be shared anyway.
Following this, I'll set up a PR to build the Remix package with the new setup, which will be a little more work since that package has some special configs. Following that, we'll build everything the new way and we'll be ready to merge the repos.