Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

[GraphQL Client][Feature] Refactor graphql-client code and add API client utilities #1023

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

melissaluu
Copy link
Contributor

@melissaluu melissaluu commented Oct 27, 2023

WHY are these changes introduced?

Refactor and clean up the graphql-client code and add set of common API client specific utilities and types.

WHAT is this pull request doing?

Add a new api-client-utilities folder that stores common utils and types that Shopify API clients can use.

Also, updated the main graphql client code for easier readability.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@melissaluu melissaluu force-pushed the ml-graphql-client-cleanup-api-utils branch from 014be47 to bb6fece Compare October 27, 2023 22:03
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Not approving since it's marked as draft, but LGTM.

@melissaluu melissaluu marked this pull request as ready for review October 30, 2023 18:45
@melissaluu melissaluu requested a review from a team as a code owner October 30, 2023 18:45
@melissaluu melissaluu requested a review from paulomarg October 30, 2023 18:45
@melissaluu melissaluu changed the title [WIP][GraphQL Client][Feature] Refactor graphql-client code and add API client utilities [GraphQL Client][Feature] Refactor graphql-client code and add API client utilities Oct 30, 2023
@melissaluu melissaluu merged commit 17ce23f into main Oct 30, 2023
10 checks passed
@melissaluu melissaluu deleted the ml-graphql-client-cleanup-api-utils branch October 30, 2023 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants