Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Handle yaml file type #9678

Merged
merged 1 commit into from
Feb 13, 2025
Merged

[MS] Handle yaml file type #9678

merged 1 commit into from
Feb 13, 2025

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Feb 12, 2025

Close #9669

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

@Max-7 Max-7 requested a review from a team as a code owner February 12, 2025 14:00
@FirelightFlagboy FirelightFlagboy linked an issue Feb 12, 2025 that may be closed by this pull request
[🐛 | Bug]: Internal editor does not support yaml file #9669
Closed
FirelightFlagboy
FirelightFlagboy reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we use mimetypes? something prevent us from using that

@Max-7 Max-7 merged commit fab8687 into releases/3.3 Feb 13, 2025
10 checks passed
@Max-7 Max-7 deleted the ms-fix-yaml-ext branch February 13, 2025 08:21
@FirelightFlagboy FirelightFlagboy mentioned this pull request Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FirelightFlagboy FirelightFlagboy FirelightFlagboy left review comments

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 | Bug]: Internal editor does not support yaml file
3 participants
@Max-7 @NicoTuxx @FirelightFlagboy