Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Updated mega menu to latest version #2884

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Aug 1, 2024

Description

  • 💄 I updated the website to use the newest version of the megamenu
  • ⬆️ Updated app insights telemetry components to fix build errors

Note: I also needed to bump a couple of dependencies which were causing build errors.

microsoft/applicationinsights-react-js#95

  • Affected routes: ssw.com.au/*

  • Fixed #93

  • Include done video or screenshots

image

Figure: new search bar on mobile devices

image

Figure: New hamburger menu on mobile devices

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.23% 69/30365
🔴 Branches 7.67% 24/313
🔴 Functions 1.03% 3/292
🔴 Lines 0.23% 69/30365

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 9d333e9

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Deployed changes to https://app-sswwebsite-9eb3-pr-2884.azurewebsites.net

Copy link
Contributor

github-actions bot commented Aug 1, 2024

PageSpeed Insights

Category Score
Accessibility 92
Best practices 96
Performance 63
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2884.azurewebsites.net

Copy link
Member

@tkapa tkapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Calinator444
Copy link
Member Author

Calinator444 commented Aug 1, 2024

Also just for the record I checked the app insights logs to make sure we were still getting telemetry on this branch.

image

@Calinator444 Calinator444 merged commit 13d305b into main Aug 1, 2024
11 checks passed
@Calinator444 Calinator444 deleted the 93-add-flag-mobile-layout branch August 1, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ SSW.com.au should have French and China flags in the mega menu (smaller screens)
2 participants