chacha20: bump rand_core to v0.9
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
chacha20/rand_core-v0.9
branch
from
5a77c14 to
0ff230f
Compare
tarcieri
commented
Jan 28, 2025
| @@ -735,7 +735,7 @@ pub(crate) mod tests { | |||
| let mut rng1 = ChaChaRng::from_seed(seed); | |||
| assert_eq!(rng1.next_u32(), 137206642); | |||
|
|
|||
| let mut rng2 = ChaChaRng::from_rng(rng1); | |||
| let mut rng2 = ChaChaRng::from_rng(&mut rng1); | |||
There was a problem hiding this comment.
This looks like some kind of nightly-only failure: https://github.com/RustCrypto/stream-ciphers/actions/runs/13020926488/job/36321197288
That said, the new code is more explicit, rather than relying on the blanket impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.