BoxedUint: change internal representation to Box<[Limb]>
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously a `Vec<Limb>`, however this encourages changing the precision of an existing `BoxedUint` when they're supposed to be fixed-precision. Using `Box<[Limb]>` decreases the on-stack size by eliminating the capacity and discourages changing the underlying precision, whereas `Vec` makes that convenient.
tarcieri
force-pushed
the
boxed-uint/use-boxed-slice-internally
branch
from
230382e to
c02e74e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously a
Vec<Limb>, however this encourages changing the precision of an existingBoxedUintwhen they're supposed to be fixed-precision.Using
Box<[Limb]>decreases the on-stack size by eliminating the capacity and discourages changing the underlying precision, whereasVecmakes that convenient.