Address BoxedUint::is_nonzero TODO (#567)

RustCrypto · Jan 28, 2024 · 2a61f1d · 2a61f1d
1 parent 6ccbe74
commit 2a61f1d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/uint/boxed.rs b/src/uint/boxed.rs
@@ -95,12 +95,10 @@ impl BoxedUint {
             .fold(Choice::from(1), |acc, limb| acc & limb.is_zero())
     }
 
-    /// Is this [`BoxedUint`] not equal to zero?
+    /// Is this [`BoxedUint`] *NOT* equal to zero?
+    #[inline]
     pub fn is_nonzero(&self) -> Choice {
-        // TODO: why not just !self.is_zero()?
-        self.limbs
-            .iter()
-            .fold(Choice::from(0), |acc, limb| acc | limb.is_nonzero().into())
+        !self.is_zero()
     }
 
     /// Is this [`BoxedUint`] equal to one?