Add Invocation Script #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammad Mahad <[email protected]>
Add `regex` and exported it for other files Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Fixes: Rust-GCC#9 Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
If the test source file doesn't contain any headers, or that are not added till now then the header value will be None and becomes panic Signed-off-by: Muhammad Mahad <[email protected]>
P-E-P
approved these changes
Oct 15, 2024
| @@ -17,6 +22,7 @@ pub struct Arguments { | |||
| )] | |||
| pub source_file: path::PathBuf, | |||
There was a problem hiding this comment.
This argument is mandatory, I wonder if we shouldn't make it a positional argument instead ? It would be shorter to write and can't be confusing if it is the only positional argument anyway.
I'd like both of your insights @MahadMuhammad @CohenArthur
There was a problem hiding this comment.
I'm happy with making it positional
CohenArthur
approved these changes
Nov 25, 2024
| echo "RUSTTEST_TO_DG_PATH: $RUSTTEST_TO_DG_PATH" | ||
|
|
||
| # Installing rusttest-to-dg | ||
| cd $RUSTTEST_TO_DG_PATH |
There was a problem hiding this comment.
Suggested change
| cd $RUSTTEST_TO_DG_PATH | |
| cd "$RUSTTEST_TO_DG_PATH" |
Comment on lines
+47
to
+49
| cp -r $RUST_PATH/tests/ui $GCCRS_PATH/gcc/testsuite/rust/rustc | ||
| echo -e "Copied $RUST_PATH/tests/ui tests to $GCCRS_PATH/gcc/testsuite/rust/rustc/ui" | ||
| cd $GCCRS_PATH/gcc/testsuite/rust/rustc/ui |
There was a problem hiding this comment.
Suggested change
| cp -r $RUST_PATH/tests/ui $GCCRS_PATH/gcc/testsuite/rust/rustc | |
| echo -e "Copied $RUST_PATH/tests/ui tests to $GCCRS_PATH/gcc/testsuite/rust/rustc/ui" | |
| cd $GCCRS_PATH/gcc/testsuite/rust/rustc/ui | |
| cp -r "$RUST_PATH"/tests/ui $GCCRS_PATH/gcc/testsuite/rust/rustc | |
| echo -e "Copied $RUST_PATH/tests/ui tests to $GCCRS_PATH/gcc/testsuite/rust/rustc/ui" | |
| cd "$GCCRS_PATH"/gcc/testsuite/rust/rustc/ui |
| else | ||
| rusttest-to-dg --file "$file" > "$output_file" | ||
| fi | ||
| mv $output_file $file |
There was a problem hiding this comment.
Suggested change
| mv $output_file $file | |
| mv "$output_file" "$file" |
| @@ -17,6 +22,7 @@ pub struct Arguments { | |||
| )] | |||
| pub source_file: path::PathBuf, | |||
There was a problem hiding this comment.
I'm happy with making it positional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add invocation script and add usage in
READMEfile