Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(CreateAchievementTicketMainRoot): speed up extremely slow test #3160

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

wescopeland
Copy link
Member

This PR speeds up a test for the create ticket page that is often so slow it fails in CI. The reason it's slow is userEvent simulates delays between keystrokes, and the input for this test case is huge.

Before
Screenshot 2025-01-30 at 9 25 07 PM

After
Screenshot 2025-01-30 at 9 23 41 PM

@wescopeland wescopeland requested a review from a team January 31, 2025 02:25
@wescopeland wescopeland merged commit 5341e2b into RetroAchievements:master Jan 31, 2025
8 checks passed
@wescopeland wescopeland deleted the ticket-slow-test branch January 31, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants