-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow users to change their names #3071
base: master
Are you sure you want to change the base?
feat: allow users to change their names #3071
Conversation
Random thought: does it auto-approve and/or allow direct edits for case changes? given that we act case-insensitive it should probably be possible to change case at will; Luchaos is the same as luchaos internally. Just bringing this up as we had case change requests in the past. |
Good question! It currently doesn't auto-approve those cases. But I think it would make a lot of sense to hunt that down in a subsequent PR before this goes live. |
This PR gives users the ability to request name changes.
How it works
A new form has been added to
/settings
:When the user attempts to submit the form, they get a confirm with this warning:
If the user confirms, the request is submitted and lives in the
user_usernames
table:(note the new
approved_at
column)In the management app, a new tool has been added:
The (1) badge indicates there is a pending username change request.
As an admin or moderator, I can view the list of pending username change requests:
If I click approve, the user's
display_name
value will be changed, something will be recorded to their account's audit log, and an email will be fired off:This is the happy path case.
Alternatively, after 30 days, the username change request will "expire". It will no longer appear in the list of active requests, and the user will be able to request a new username change.
Other notes:
display_name
, users do have the ability to request reverting back to their original username (they can bypass this uniqueness check).display_name
.display_name
change is approved, users are put on a 30 day cooldown before they can request another change.