Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new expando button design #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

githue
Copy link

@githue githue commented Mar 21, 2016

Closes honestbleeps/Reddit-Enhancement-Suite#2738

This is intended to fit over the top of the new expando button CSS that Reddit is currently using in AB testing. It should only be published when reddit switches all users to the new design. If you only want to target users currently using the new design, then you'd need to use JS to detect it.

  • The image source will need to be changed.

@jewel-andraia
Copy link
Member

for quick ref:

@jewel-andraia jewel-andraia modified the milestone: v4.6.1 hotfix Mar 21, 2016
@githue
Copy link
Author

githue commented Mar 21, 2016

Oh that's an older image with a bigger file size, use this one instead:

Forgot to replace the URL in the code.

@jewel-andraia
Copy link
Member

Thanks for new URL. I added a checklist item for updating that.

@jewel-andraia jewel-andraia self-assigned this Mar 21, 2016
@githue
Copy link
Author

githue commented Mar 29, 2016

Looks like it will change at some point and won't arrive for some time.

https://www.reddit.com/r/announcements/comments/4ch0pv/updates_to_our_media_previews/d1i4b1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants