Uncoordintated omission - validating http load genertaors with bpf_validator #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz1981
requested changes
Dec 19, 2024
|
|
||
| https://github.com/johnaohara/bpf_validator/[bpf_validator] allows us to independently verify that the numbers produced by a Load Driver are not biased, and contain the full sample count. | ||
|
|
||
| He tested against https://hyperfoil.io/[Hyperfoil] and https://github.com/giltene/wrk2[wrk2] to confirm the results presented by Hyperfoil are a accurate representation of what happened during a load test. |
There was a problem hiding this comment.
Suggested change
| He tested against https://hyperfoil.io/[Hyperfoil] and https://github.com/giltene/wrk2[wrk2] to confirm the results presented by Hyperfoil are a accurate representation of what happened during a load test. | |
| We tested against https://hyperfoil.io/[Hyperfoil] and https://github.com/giltene/wrk2[wrk2] to confirm the results presented by Hyperfoil are a accurate representation of what happened during a load test. |
| --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ | ||
| -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \ | ||
| --\___\_\____/_/ |_/_/|_/_/|_|\____/___/ | ||
| 2024-12-03 14:59:37,947 INFO [io.quarkus] (Quarkus Main Thread) code-with-quarkus 1.0.0-SNAPSHOT on JVM (powered by Quarkus 3.17.2) started in 2.072s. Listening on: http://localhost:8000 |
There was a problem hiding this comment.
2 seconds is a lot - this is running in dev mode for some reason?
I mean, TBH is not important, just curiousity
| #[Buckets = 27, SubBuckets = 2048] | ||
| ---------------------------------------------------------- | ||
| 92597 requests in 20.00s, 9.01MB read <6> | ||
| Socket errors: connect 5, read 0, write 0, timeout 40 |
There was a problem hiding this comment.
socket errors? Some have been timed out...are important info?
franz1981
reviewed
Dec 19, 2024
| Av Throughput: 5142.425405 req/sec <6> | ||
|
|
||
| ---- | ||
| <1> The average RTT was 0.240 ms |
There was a problem hiding this comment.
The order and phrasing content in the bullet points is slightly different from the one to compare with i.e. https://github.com/RedHatPerf/redhatperf.github.io/pull/21/files#diff-e4c84ea749a91a7a6497412e17ff5f4973aec06e593c39f88e6c5abab5211a6aR432
and my eyes are flipping to detect which parts are relevant/different for comparison
A tabular/summary/chart view would help IMO
barreiro
reviewed
Dec 20, 2024
| * a) accurate | ||
| * b) reporting summary results from all the sample | ||
|
|
||
| A eBPF script https://github.com/johnaohara/bpf_validator/[bpf_validator] allows us to inject a secondary validation tool directly into the network stack of the Linux Kernel, to record the measure all requests and responses observed from the network layer. After a load driver run has completed, the https://github.com/johnaohara/bpf_validator/[bpf_validator] will output summary statistics that can be used to validate the statistics reported by the load driver. |
There was a problem hiding this comment.
Suggested change
| A eBPF script https://github.com/johnaohara/bpf_validator/[bpf_validator] allows us to inject a secondary validation tool directly into the network stack of the Linux Kernel, to record the measure all requests and responses observed from the network layer. After a load driver run has completed, the https://github.com/johnaohara/bpf_validator/[bpf_validator] will output summary statistics that can be used to validate the statistics reported by the load driver. | |
| A eBPF script https://github.com/johnaohara/bpf_validator/[bpf_validator] allows us to inject a secondary validation tool directly into the network stack of the Linux Kernel, to measure all requests and responses observed from the network layer. After a load driver run has completed, the https://github.com/johnaohara/bpf_validator/[bpf_validator] will output summary statistics that can be used to validate the statistics reported by the load driver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.