Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/minimal: disable threading #21103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests/minimal: disable threading #21103

wants to merge 1 commit into from

Conversation

benpicco
Copy link
Contributor

Contribution description

We can get even more minimal by disabling support for threads.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 22, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 22, 2024
@riot-ci
Copy link

riot-ci commented Dec 22, 2024 •
edited
Loading

Murdock results

❌ FAILED

cb9661b tests/minimal: disable threading

Success Failures Total Runtime
13 0 19 18s

Artifacts

@maribu
Copy link
Member

maribu commented Dec 22, 2024

Goos one, it directly uncovered a bug

@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 20, 2025
@MrKevinWeiss
Copy link
Contributor

Is the bug fixed? Let's see!

@benpicco
Copy link
Contributor Author

not really a but - platforms that use the idle thread don't work without core_thread

@miri64
Copy link
Member

miri64 commented Jan 20, 2025

not really a but - platforms that use the idle thread don't work without core_thread

Can this maybe be modeled as and made dependent on a feature?

@MrKevinWeiss
Copy link
Contributor

We can sort it out after the hard freeze then.

@MrKevinWeiss MrKevinWeiss added State: waiting for end of feature-freeze Process: blocked by feature freeze Integration Process: The impact of this PR is too high for merging it during soft feature freeze. labels Jan 21, 2025
@MrKevinWeiss MrKevinWeiss removed the Process: blocked by feature freeze Integration Process: The impact of this PR is too high for merging it during soft feature freeze. label Jan 21, 2025
@MrKevinWeiss
Copy link
Contributor

Freeze is over so if anyone wants to pick this up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @riot-ci @maribu @MrKevinWeiss @miri64