Skip to content

core/sync: add wait queues #27581

core/sync: add wait queues

core/sync: add wait queues #27581

Triggered via pull request January 8, 2025 19:41
Status Failure
Total duration 3m 6s
Artifacts

static-test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 5 warnings
static-tests: core/include/wait_queue.h#L127
Member list (variable) of struct wait_queue_t is not documented.
static-tests: core/include/wait_queue.h#L1
Member wait_queue_entry_t (typedef) of group core_sync_wait_queue is not documented.
static-tests
Process completed with exit code 2.
static-tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
static-tests: core/include/wait_queue.h#L213
too many consecutive empty lines
static-tests: core/include/sched.h#L191
Uncrustify proposes the following patch: --- a/core/include/sched.h +++ b/core/include/sched.h @@ -185,7 +185,7 @@ typedef enum { */ #define STATUS_ON_RUNQUEUE STATUS_RUNNING /**< to check if on run queue: `st >= STATUS_ON_RUNQUEUE` */ -#define STATUS_NOT_FOUND ((thread_status_t)~0) /**< Describes an illegal thread status */ +#define STATUS_NOT_FOUND ((thread_status_t) ~0) /**< Describes an illegal thread status */ /** @} */ /** * @def SCHED_PRIO_LEVELS diff --git a/core/thread.c b/core/thread.c index 0c7387b926..860f7c7cee 100644
static-tests: core/thread.c#L264
Uncrustify proposes the following patch: --- a/core/thread.c +++ b/core/thread.c @@ -257,8 +257,8 @@ kernel_pid_t thread_create(char *stack, int stacksize, uint8_t priority, * Make sure the TLS area is aligned as required and that the * resulting stack will also be aligned as required */ - thread->tls = (void *) ((uintptr_t) tls & ~ (TLS_ALIGN - 1)); - stacksize = (char *) thread->tls - stack; + thread->tls = (void *)((uintptr_t)tls & ~(TLS_ALIGN - 1)); + stacksize = (char *)thread->tls - stack; _init_tls(thread->tls); #endif diff --git a/core/wq.c b/core/wq.c index 6c90ec14bc..50e5a81c4b 100644
static-tests: core/wq.c#L60
Uncrustify proposes the following patch: --- a/core/wq.c +++ b/core/wq.c @@ -54,7 +54,7 @@ void _prepare_to_wait(wait_queue_t *wq, wait_queue_entry_t *entry) *entry = (wait_queue_entry_t) { .thread = thread_get_active(), - .next = NULL, + .next = NULL, }; _wait_enqueue(wq, entry, irq_state);