Added first set of bioconductor-msnbase tools #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorainer feel free to have a look :) |
|
Nice! only single comment would be that I would suggest to switch (in the longer run) to MsExperiment and Spectra - MSnbase will not be extended/updated in future. |
|
Ah - maybe unrelated - but we have now also ways to store data & results in an RData independent manner: MsIO, different possibilities are available, from plain txt to json, hdf5... |
bgruening
reviewed
Jan 24, 2025
bgruening
reviewed
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tools wrapping the following functions from bioconductor-msnbase
Tests are available for all tools and are covered using <assert_contents> statements.