Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

galaxy wrapper for the scp tool #625

Merged
merged 85 commits into from
Jan 22, 2025
Merged

Conversation

KristinaGomoryova
Copy link
Collaborator

This PR includes the galaxy wrapper for the scp, an R package for the mass spectrometry-based single cell data analysis. All the package functionality is built into a one tool, where user can pre-define all settings. Several graphs are outputted.

@hechth hechth requested review from bgruening and hechth January 6, 2025 12:48
@hechth
Copy link
Member

hechth commented Jan 9, 2025

@bgruening the tests are passing and seem fine with conda but it doesn't work with the biocontainers for some reason. It can't find the Rscript command - do you have some idea of what is going on there?

@bgruening
Copy link
Collaborator

Where do you see the error with RScript. On CI the error is a different diff on Test 2.
(I'm a bit worried about the strange symbols in the output)

Collection element QC_boxplot_peptide of collection plots:  different than expected, difference (using diff):
( /tmp/tmpj0sk7c5nQC_boxplot_peptide.pdf v. /tmp/tmpf91yf51dQC_boxplot_peptide.pdf )
--- local_file
+++ history_data
@@ -2,8 +2,8 @@
 %�����\r
 1 0 obj
 <<
-/CreationDate (D:20250109160515)
-/ModDate (D:20250109160515)
+/CreationDate (D:20250109153657)
+/ModDate (D:20250109153657)
 /Title (R Graphics Output)
 /Producer (R 4.4.2)
 /Creator (R)
@@ -17,28 +17,21 @@
 endobj
 8 0 obj
 <<
-/Length 7685 /Filter /FlateDecode
+/Length 7677 /Filter /FlateDecode
 >>
 stream
-x��]K�%�m��_q���'�~,-#6`������!���0#9���������Ⱥz��l��
���&��:����|�������_~��㳯_��9���_���{�Gvi���_�>�������{�y��
���}|�}���?}����ӼZ������>~������}����~���~y|,
��L��C}����=cz�
���@
�������={���;�p�
����A����x��\|���7tC�������sC��Y��sC���۹��y��f�(�g	�����&��h�pC/���
��5�)=,o�XN��
���Ų�����{�Ss<o��g�����9E��;��;�3,�;��W\W���׶�x��
e(s��{����=�e������R�
|6n
�7�̣�������[��A<eƫ�+S���u?s_ n6���������=}G����
-��O��-�ا�� �������>}`�R�!1�
����s�������{��~�}�y��V;����p���� ����
�������g�I!�O�����xU��ҳye<���Oy�"Ƴ�4�=J����XTa��?5�ѵ�&�
-�����,<ūf�?kS�o�Dj`��7���Qbp�#Ԧ�_��F�-�I.�m�]8�>�����Glh��]�;��.����O�b�.��w��0����]�����}w�}�)^��8��g`?��
T7�8��;z���}
]
2
�M��.���	oX�pA����>]`n���U�~M�����1�"G�p���`�٣��7
��*����������x���f�)^5�#�8�����H�
��:p�Qbp�������g=��=�	�
@�Y��)× yÕ®;���<é�ºï¿½ï¿½RI0�@�ݣ�l&����#O�����g:�g��yÖ��HbÒ¼j��3��o��}����� ���}�#`QE�Ë��Kì�������}�S����ܳ���F�5Ê�,ik���ht'&�#`Q��{�����D"�7���
���S����iVl0�=��I��$Ƴ��}�%�7
��*��S��a��6muL[�O�]wÌ b��z�����S\-�]w�Jl������g�t�ZItJ�F�u����4����
�ug4�ۯ�b:�Z���G���'Q4(���z1�!i8�,J��g�
'V��y���g/f�]�R���W��Q�}�`�{Q�U���;���}�1V6ͫ
����3�#
-�����g�	O�g�������!p����N�<��T�h�e�
(�r]�h'��x��y����FwY@x�,�P4���K+����@Ѱ/07
O�K�>�,��{�(����f5{)������G��-��a�� �3J�$���0�
�C	M��~�3sB�Oa�
�G�
y����O�;��
�^�4]p���x���IT7��ʾ�ܸS�	UӮTӮtq��������J�*��N�R�����/@@�nW��s�]�j#O�g�W�<)@�I�D��0�c�I6�Da��A��7�Ƴ.
S�]��b��T�YL��E���<��d<�L��
********
*SNIP *
********
 << /Type /Pages /Kids [ 7 0 R ] /Count 1 /MediaBox [0 0 504 504] >>
@@ -83,16 +76,16 @@
 0000000000 65535 f 
 0000000021 00000 n 
 0000000163 00000 n 
-0000008049 00000 n 
-0000008132 00000 n 
-0000008244 00000 n 
-0000008277 00000 n 
+0000008041 00000 n 
+0000008124 00000 n 
+0000008236 00000 n 
+0000008269 00000 n 
 0000000212 00000 n 
 0000000292 00000 n 
-0000010972 00000 n 
-0000011229 00000 n 
+0000010964 00000 n 
+0000011221 00000 n 
 trailer
 << /Size 11 /Info 1 0 R /Root 2 0 R >>
 startxref
-11326
+11318
 %%EOF

@bgruening
Copy link
Collaborator

Ah its a PDF. PDF is hard to compare unfortunately. Maybe just check the size?

@hechth
Copy link
Member

hechth commented Jan 9, 2025

crazy, if I try running it with biocontainers I get a different error - cool, yeah will do size diff then

@hechth
Copy link
Member

hechth commented Jan 9, 2025

The bio.tools entry so far is just a dummy but the website seems somehow lagging a lot. Will update the record as soon as that will be fixed.

Copy link
Collaborator

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @KristinaGomoryova! Well done. This looks very good to me!

Not sure about Martin's last question, but from me +1!

Thanks a lot!

@hechth hechth merged commit a0a1a3d into RECETOX:master Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants