-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store selected kernel and toolbox in .jpblockly file #103
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this @Phoenix616! I approved the workflows run. Can you try to fix the failing test? It seems to be a linting issue. |
Sure, it didn't show that locally for me though. How do you build it correctly to trigger the linter to check the code? Because neither the build command from the README.md nor RELEASE.md did make this show up and only being able to check that on github seems pretty inefficient. EDIT: Ah, saw it in the action now, it seems to be |
|
Ah, right, that would explain it. I didn't manage to set that up properly as I run builds via WSL but commit via IntelliJ running on Windows. I remember there being an issue getting it to build originally and forgot to run the pre-commit stuff manually after finally getting it at least to build for me. Just tested directly in WSL and it seems to run fine when doing the commit there too so there is no issue with the project setup itself at least. |
Code style issues should all be fixed now. |
This adjusts the format of the .jpblockly files to allow storing of additional metadata similarly to .ipynb files: It stores the selected kernel and toolbox as well as adds the ability to define a list of allowed blocks.
While improving the experience when using the Blockly editor (as one doesn't need to select the kernel and toolbox manually on each file open) this also makes it possible to distribute pre-configured files for certain types of content e.g. for exercises that should be done only with certain blocks.
Old file in the previous format are loaded and automatically stored in the new one on the next save.