Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gif #13616

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Remove gif #13616

wants to merge 7 commits into from

Conversation

abbycross
Copy link
Collaborator

@abbycross abbycross commented Jan 6, 2025

Closes Qiskit/documentation#2533. See discussion on this issue for context.

@abbycross abbycross requested a review from a team as a code owner January 6, 2025 15:42
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@abbycross abbycross self-assigned this Jan 6, 2025
@abbycross abbycross added the documentation Something is not clear or an error documentation label Jan 6, 2025
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12672849918

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 88.94%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.98%
crates/qasm2/src/parse.rs 6 97.62%
Totals Coverage Status
Change from base Build 12670558519: -0.004%
Covered Lines: 79442
Relevant Lines: 89321

💛 - Coveralls

Comment on lines -890 to -896
A particularly important circuit property is known as the circuit :meth:`depth`. The depth
of a quantum circuit is a measure of how many "layers" of quantum gates, executed in
parallel, it takes to complete the computation defined by the circuit. Because quantum
gates take time to implement, the depth of a circuit roughly corresponds to the amount of
time it takes the quantum computer to execute the circuit. Thus, the depth of a circuit
is one important quantity used to measure if a quantum circuit can be run on a device.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph might be worth preserving? It's helpful to mention we have the method depth.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I thought we were removing entirely. I can move this part of the explanatory info to the description in https://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.QuantumCircuit#depth like Jake suggested

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drafted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something is not clear or an error documentation
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Deal with large and inaccessible Qiskit GIF
4 participants