Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
* Add existing project files * Black autocorrect * autopep8 fixes * Fix pylint warnings - Import order - Variable name from "g" to "github" * Fixed all pylint errors except module docstring errors * Removes nearly all pylint warnings Remaining warnings: - `too-many-locals` x3 - `consider-using-enumerate` x` - `no-value-for-parameter` x2 Co-authored-by: lei56 <[email protected]>
* Remove Swift+Vapor server * Delete swiftlint.yml
Co-authored-by: lei56 <[email protected]>
* Fixed minor issues in run, removed sys.exit calls that would crash GCP VM, and implemented simple authentication scheme. WIP: integrate authenticator into main, and make a legitimate token generation scheme * Converted original test.py to a unittest suite * Implemented new scoring metric, update score. Implemented package ingestion. Both have new unit tests in test.py * Fix pylint warnings (#48) * Update authenticateTest.py Fix pylint warnings * Update authenticate.py * Update ingest.py * Update perform.py Co-authored-by: Charles Pisciotta <[email protected]>
File has been integrated into test.py
integrated with test.py
moved to Scoring subdirectory
moved to Scoring subdirectory
Add test cases
Added dependencies to pylint.yaml
Added beautifulsoup4 to pylint.yaml
Added github access token environment variable
Reintroduced ingestion field for empty content string
* Implement delete package TODO * Add assertion for "x" in version request string * Add `isAdmin` check to reset registry * Wrap mock objects in DEBUG check * Change update status code on error * Fix rating status codes for no such package and scores unavailable * Fix rating when scores not yet available * DELETE should stay * Change name of new score from "goodPinningPractice" to "updateScore"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @cpisciotta @lei56 @reid63