Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme with contributing guidelines. #2

Open
wants to merge 1 commit into
base: general-devel
Choose a base branch
from
Open

Update Readme with contributing guidelines. #2

wants to merge 1 commit into from

Conversation

DogooFalchion
Copy link
Contributor

Adding in project flow for contributing.

hakusaro
hakusaro requested changes Oct 29, 2016
View reviewed changes
Copy link
Member

@hakusaro hakusaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in CONTRIBUTING.md?

@AxisKriel
Copy link
Member

That's the convention, yeah. Might wanna migrate files.

@DogooFalchion
Copy link
Contributor Author

While contributing is nice, the readme is the first thing you see when you open the page. Putting it in a contributing page doesnt show it unless the user actually clicks on it, in which case it might be too late to put in the issue and wasted time. But its up to you, if you think it shouldnt be in the readme close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakusaro hakusaro hakusaro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DogooFalchion @AxisKriel @hakusaro