Neighborhood hover not working on our maps in Firefox #3777 #3796
Conversation
| // Add listeners to popup so the popup closes when the mouse leaves the popup area. | ||
| neighborhoodTooltip._content.onmouseout = function (e) { | ||
| if (!e.toElement || !e.toElement.closest('.mapboxgl-popup')) { | ||
| // Clear timeout when entering new toolTip |
There was a problem hiding this comment.
Very small thing, but just take a quick look through the Style Guide. Want comments ending in a period, etc. Sorry, still need to get the linter set up to do this stuff automatically!
| // Clear timeout when entering new toolTip | ||
| neighborhoodTooltip._content.onmouseenter = function () { | ||
| if (tooltipTimeout) { | ||
| clearTimeout(tooltipTimeout); // Clear the timeout if the mouse enters the tooltip |
There was a problem hiding this comment.
This comment also feels redundant. The outer comment summarizes what happens here well enough, and what you're doing is simple enough. I think it would be cleaner to just rewrite it like:
// Clear timeout when entering a tooltip.
neighborhoodTooltip._content.onmouseenter = function () {
if (tooltipTimeout) clearTimeout(tooltipTimeout);
};
| // Clear timeout when entering new toolTip | ||
| neighborhoodTooltip._content.onmouseenter = function () { | ||
| if (tooltipTimeout) { | ||
| clearTimeout(tooltipTimeout); // Clear the timeout if the mouse enters the tooltip |
There was a problem hiding this comment.
And when we call clearTimeout we're actually never unsetting the tooltipTimeout variable. So after the first tooltip opens, tooltipTimeout will never be falsey. Which is fine, because we can keep trying to clear the timeout for a timer that's already been cleared. Similarly, we can keep calling clearTimeout on undefined! So maybe let's just not bother with checking if tooltipTimeout is defined to simplify things even more:
// Clear timeout when entering a tooltip.
neighborhoodTooltip._content.onmouseenter = function () { clearTimeout(tooltipTimeout); };
And we can simplify in the same way throughout
|
And make sure to pull in most recent changes to develop! You were behind by 25 commits or so, but I pulled in changes while I was testing this time! |
Resolves #3777
Configured tooltopTimout variable to handle flickering on toolbox when hovered by adding slight delay when removing tool tip which gives the user time to move their mouse onto the tooltip.
Before/After screenshots (if applicable)
before.mp4
after.mp4
Testing instructions
Things to check before submitting the PR